HuaHuaY commented on code in PR #50252:
URL: https://github.com/apache/arrow/pull/50252#discussion_r3654109708
##########
cpp/src/arrow/extension/parquet_variant.cc:
##########
@@ -57,50 +59,148 @@ std::string VariantExtensionType::Serialize() const {
return ""; }
std::shared_ptr<Array> VariantExtensionType::MakeArray(
std::shared_ptr<ArrayData> data) const {
DCHECK_EQ(data->type->id(), Type::EXTENSION);
- DCHECK_EQ("arrow.parquet.variant",
+ DCHECK_EQ(kVariantExtensionName,
internal::checked_cast<const
ExtensionType&>(*data->type).extension_name());
return std::make_shared<VariantArray>(data);
}
namespace {
-bool IsBinaryField(const std::shared_ptr<Field> field) {
- return field->type()->storage_id() == Type::BINARY ||
- field->type()->storage_id() == Type::LARGE_BINARY;
+
+bool IsSupportedPrimitiveTypedValue(const std::shared_ptr<DataType>& type) {
Review Comment:
Discussion at: https://github.com/apache/arrow/issues/50622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
