taepper commented on code in PR #50653:
URL: https://github.com/apache/arrow/pull/50653#discussion_r3655935832
##########
cpp/src/arrow/json/from_string.cc:
##########
@@ -360,22 +443,22 @@ class DecimalConverter final
Status Init() override { return this->MakeConcreteBuilder(&builder_); }
- Status AppendValue(const rj::Value& json_obj) override {
- if (json_obj.IsNull()) {
+ Status AppendValue(sj::value& json_obj) override {
+ if (json_obj.is_null()) {
return this->AppendNull();
}
- if (json_obj.IsString()) {
+ std::string_view string_value;
+ if (json_obj.get<std::string_view>(string_value) == simdjson::SUCCESS) {
Review Comment:
We don't. Oversight on my part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
