C-Loftus opened a new pull request, #1028:
URL: https://github.com/apache/arrow-go/pull/1028

   ### Rationale for this change
   
   #969 added an interface for a custom arrow type on read for arrow extension 
types. This allows a type like geometry to be resolved to the underlying arrow 
physical type like byte array.
   
   However, I went to implement this in geoarrow-go today and upon further 
investigation I think the interface name is slightly confusing. The interface 
`ExtensionParquetLogicalType` doesn't actually include the `ParquetLogicalType` 
method but rather it intended to be used to specify the arrow type from parquet 
on read. As such I have renamed it.
   
   I figure it makes sense to solidify this before creating a new arrow-go 
release and adding it to iceberg-go whereupon it will be much harder to change.
   
   I changed the interface name to indicate that it is one side of the 
read/write path for extension types. I think this is a bit more clear but if I 
am misunderstanding and it might be used in both read and write, then maybe it 
doesn't make sense.
   
   ### What changes are included in this PR?
   
   Comments and a change in the name of an interface. This interface is not yet 
in a published release but is on main. Since its only been a few days, I think 
it is reasonable to change this. 
   
   ### Are these changes tested?
   
   Yes
   
   ### Are there any user-facing changes?
   
   Yes. Change in interface name. But no changes in behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to