zanmato1984 commented on code in PR #50625:
URL: https://github.com/apache/arrow/pull/50625#discussion_r3659604987
##########
cpp/src/arrow/compute/kernels/scalar_if_else.cc:
##########
@@ -2756,38 +2754,42 @@ void AddCaseWhenKernel(const
std::shared_ptr<CaseWhenFunction>& scalar_function,
}
void AddPrimitiveCaseWhenKernels(const std::shared_ptr<CaseWhenFunction>&
scalar_function,
- const std::vector<std::shared_ptr<DataType>>&
types) {
+ const std::vector<std::shared_ptr<DataType>>&
types,
+ std::shared_ptr<MatchConstraint> constraint) {
for (auto&& type : types) {
auto exec = GenerateTypeAgnosticPrimitive<CaseWhenFunctor>(*type);
- AddCaseWhenKernel(scalar_function, type, std::move(exec));
+ AddCaseWhenKernel(scalar_function, type, std::move(exec), constraint);
Review Comment:
This is in a loop so I don't think `std::move` is proper here. I've changed
the parameter type to const ref to eliminate the ambiguity. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
