anxkhn commented on code in PR #50368:
URL: https://github.com/apache/arrow/pull/50368#discussion_r3659768406
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2797,17 +2797,17 @@ def test_assume_timezone():
pc.assume_timezone(nonexistent_array,
options=options_nonexistent_raise)
- expected = pa.array(nonexistent.tz_localize(
- timezone, nonexistent="shift_forward"))
result = pc.assume_timezone(
nonexistent_array, options=options_nonexistent_latest)
- expected.equals(result)
-
expected = pa.array(nonexistent.tz_localize(
- timezone, nonexistent="shift_backward"))
+ timezone, nonexistent="shift_forward"), type=result.type)
Review Comment:
good catch. i changed the expected type to
`pa.timestamp(input_array.type.unit, tz=timezone)`, so the test now derives
precision from the input contract and will fail if the kernel returns the wrong
unit. the four dst cases pass with the explicit type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
