birschick-bq commented on issue #4589:
URL: https://github.com/apache/arrow-adbc/issues/4589#issuecomment-5095329693
@lidavidm
My guidelines for spans and converting logs to span events ...
- spans should be started (probably exclusively) from public API methods
(`ExecuteQuery`, `ExecuteUpdated`, `GetInfo`, etc.)
- existing logging, if converted to tracing should
- not duplicate recording duration that is already handled by the span
- not duplicate recording errors that are already handled by the span
helper (`internal.EndSpanWithError()`).
- consider adding a attribute to the events to indicate whether the event
is warning, informational or debug level of information.
- only add events for repetitive tasks if part of a batch and not for
either `m` columns or `n` rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
