fallintoplace opened a new pull request, #1033:
URL: https://github.com/apache/arrow-go/pull/1033

   ### Rationale for this change
   
   The adaptive bloom filter constructor accepted invalid configuration values. 
A false-positive probability of one could loop indefinitely in non-assertion 
builds, while a maximum size below the minimum could create a zero-byte filter 
that later panicked during insertion.
   
   ### What changes are included in this PR?
   
   * Reject false-positive probabilities outside the open interval `(0, 1)`, 
including NaN.
   * Clamp the maximum allocation to the supported bloom-filter size range.
   * Keep the existing constructor signature and small-size fallback behavior.
   
   ### Are these changes tested?
   
   Yes. The tests cover invalid probabilities and a zero-byte requested 
maximum, including insertion into the resulting minimum-sized filter. The full 
`parquet/metadata` package passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to