fallintoplace opened a new pull request, #1035:
URL: https://github.com/apache/arrow-go/pull/1035

   ### Rationale for this change
   
   Fixed-length byte-array constructors reject non-positive widths, but 
`PrimitiveNode.SetTypeLength` allowed an existing valid node to be mutated to 
zero or a negative width. The invalid node could then be serialized or passed 
to encoders.
   
   ### What changes are included in this PR?
   
   * Reject non-positive widths when mutating fixed-length byte-array nodes.
   * Leave non-fixed-width primitive nodes unchanged, preserving the existing 
no-op behavior.
   * Document the panic contract on the setter.
   
   ### Are these changes tested?
   
   Yes. The regression test covers zero and negative widths, verifies that 
failed mutations preserve the previous width, and checks the existing no-op 
behavior for other physical types. The full `parquet/schema` package passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to