CurtHagenlocher opened a new pull request, #4605: URL: https://github.com/apache/arrow-adbc/pull/4605
Apache.Arrow.Adbc.Testing guarded its net472 target framework behind IsWindows. Packaging runs in a Linux container (compose.yaml uses mcr.microsoft.com/dotnet/sdk:10.0), so TargetFrameworks collapsed to net8.0;net10.0 there and the package published to nuget.org has been missing its lib/net472 folder. It is the only test project on the release push list in dev/release/post-07-csharp.sh, so this affects consumers targeting .NET Framework. Target net472 unconditionally instead, matching what the src/Drivers projects already do, so the package contents no longer depend on which platform packs it. net472 still cannot be *run* off Windows, as there is no .NET Framework test host there, so csharp_test.sh now runs the other target frameworks individually on Linux and macOS. The list is read back from the project rather than hardcoded, so adding a target framework later cannot silently drop it from CI. xunit.runner.visualstudio 3.1.5 is used for the .NET targets and 2.8.2 for net472, selected by condition in Directory.Packages.props. Two related CI fixes: - csharp.yml requested a single SDK per matrix leg while the project multi-targets net8.0 and net10.0. The .NET 8 SDK cannot build net10.0, so that leg only worked because the runner image happened to preinstall .NET 10. Install both SDKs in every job and drop the now-redundant dotnet axis, which was producing identical jobs. - Benchmarks is packable by default and produced a Benchmarks.nupkg that was built into the release artifacts but never published. Mark it IsPackable=false. Closes #4604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
