eitsupi opened a new pull request, #4608: URL: https://github.com/apache/arrow-adbc/pull/4608
`<KnownFolders.h>` and `<ShlObj.h>` are spelled the way the Windows SDK ships them. mingw-w64 ships these headers all-lowercase (`knownfolders.h`, `shlobj.h`). Windows filesystems are case-insensitive, so the lowercase spelling resolves under both the SDK and mingw-w64, while the CamelCase spelling only resolves when the lookup is case-insensitive. The practical effect is that the driver manager currently cannot be compiled from a case-sensitive filesystem, which rules out cross-compiling for Windows from Linux. Verified with https://github.com/mstorsjo/llvm-mingw 20260616 (clang 22.1.8, mingw-w64 15.0), compiling `c/driver_manager/adbc_driver_manager.cc` with no include shims: ``` $ aarch64-w64-mingw32-clang++ -std=gnu++17 -O2 -Wall -DADBC_EXPORT= \ -Ic/include -Ic -Ic/vendor -c c/driver_manager/adbc_driver_manager.cc # before c/driver_manager/adbc_driver_manager.cc:33:10: fatal error: 'KnownFolders.h' file not found # after (ok) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
