dmsa-or commented on code in PR #50642:
URL: https://github.com/apache/arrow/pull/50642#discussion_r3663226604
##########
cpp/src/arrow/compute/kernels/scalar_round_arithmetic_test.cc:
##########
@@ -507,218 +507,180 @@ TEST(TestUnaryRound, DispatchBestRound) {
}
}
-class TestUnaryRoundArithmeticDecimal : public TestRoundArithmeticDecimal {};
+// Const ndigits test case used by both TestUnaryRoundArithmeticDecimal and
+// TestBinaryRoundArithmeticDecimal
+struct RoundDecimalTestCase {
+ std::string kind; // "CheckScalar" or "CheckRaises"
Review Comment:
`StatusCode` didn't seem like the best fit. I made an enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
