Reranko05 commented on code in PR #50672:
URL: https://github.com/apache/arrow/pull/50672#discussion_r3663362364
##########
cpp/src/arrow/json/object_parser.cc:
##########
@@ -30,7 +30,10 @@ class ObjectParser::Impl {
padded_json_ = simdjson::padded_string(json);
// Store parsed document
- document_ = parser_.iterate(padded_json_);
+ auto document_result = parser_.iterate(padded_json_);
+ if (auto error = std::move(document_result).get(document_)) {
Review Comment:
@rok I considered that, but since each call site has slightly different
error handling and messages, I wasn't sure a helper would improve readability.
Let me know if you would prefer that approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
