pitrou commented on code in PR #50679:
URL: https://github.com/apache/arrow/pull/50679#discussion_r3663834220
##########
cpp/src/parquet/level_conversion.h:
##########
@@ -18,39 +18,29 @@
#pragma once
#include <cstdint>
+#include <format>
Review Comment:
We'll see what CI says, but I'm afraid `std::format` might not be supported
on all our CI platforms.
##########
cpp/src/parquet/level_conversion.cc:
##########
@@ -119,11 +115,6 @@ void DefRepLevelsToListInfo(const int16_t* def_levels,
const int16_t* rep_levels
} else if (valid_bits_writer.has_value()) {
output->values_read = valid_bits_writer->position();
}
- if (output->null_count > 0 && level_info.null_slot_usage > 1) {
- throw ParquetException(
- "Null values with null_slot_usage > 1 not supported."
- "(i.e. FixedSizeLists with null values are not supported)");
- }
Review Comment:
Are we ok removing this? Is it handled elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
