taepper commented on PR #50653: URL: https://github.com/apache/arrow/pull/50653#issuecomment-5102096659
> Hmm, this CI error looks related: https://github.com/apache/arrow/actions/runs/30342146109/job/90219928526?pr=50653 > > (perhaps my suggestion re `Status::operator&` was wrong? sorry) Yes, it is related. Nono, the mistake was on my part. But yes, consuming more elements from the iterator after an error is UB in simdjson. Sloppy by me. I refactored it and found a much cleaner solution to only template the `expected_size` to the function. Then we do not need to fold and can just have a loop. (Also, we can you `RETURN_NOT_OK`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
