haohuaijin opened a new pull request, #10450: URL: https://github.com/apache/arrow-rs/pull/10450
# Which issue does this PR close? - Follow-on to #10141, addressing https://github.com/apache/arrow-rs/pull/10141#issuecomment-5100991012 # Rationale for this change #10141 changed `RowSelection::iter` from `impl Iterator<Item = &RowSelector>` to a named type, `RowSelectionIter<'_>`. As @Jefffrey pointed out, the opaque return type is worth keeping so we stay free to change the implementation later. # What changes are included in this PR? `RowSelection::iter` returns `impl Iterator<Item = &RowSelector>` again. Both match arms are already `std::slice::Iter<'_, RowSelector>`, so `RowSelectionIter` is not needed at all and is removed rather than made private. No behaviour change. # Are these changes tested? Covered by the existing `RowSelection` tests, which call `iter()` on both backings. `cargo test -p parquet --all-features` passes. # Are there any user-facing changes? No. `RowSelectionIter` was added in #10141 and never released, and `iter()` keeps the `Iterator<Item = &RowSelector>` contract callers already relied on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
