pitrou commented on code in PR #50682:
URL: https://github.com/apache/arrow/pull/50682#discussion_r3664806334
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -189,16 +191,15 @@ void LevelDecoder::SetDataV2(int32_t num_bytes, int16_t
max_level,
int LevelDecoder::Decode(int batch_size, int16_t* levels) {
const int num_values = std::min(num_values_remaining_, batch_size);
- const int num_decoded = impl_->GetBatch(levels, num_values);
- if (num_decoded > 0) {
- internal::MinMax min_max = internal::FindMinMax(levels, num_decoded);
Review Comment:
If this is the only place where `FindMinMax` is used, we can also remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
