pitrou commented on code in PR #50611:
URL: https://github.com/apache/arrow/pull/50611#discussion_r3665470596


##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -346,21 +346,42 @@ endmacro()
 macro(append_runtime_sve128_src SRCS SRC)
   if(ARROW_HAVE_RUNTIME_SVE128)
     list(APPEND ${SRCS} ${SRC})
-    set_source_files_properties(${SRC} PROPERTIES COMPILE_OPTIONS 
"${ARROW_SVE128_FLAGS}")
+    set(_flags ${ARROW_SVE128_FLAGS})

Review Comment:
   @kou Do these CMake changes look ok?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to