HuaHuaY commented on code in PR #9619:
URL: https://github.com/apache/arrow-rs/pull/9619#discussion_r3666864603
##########
parquet/src/file/statistics.rs:
##########
@@ -139,6 +139,8 @@ pub(crate) fn from_thrift_page_stats(
.transpose()?;
// Generic distinct count (count of distinct values occurring)
let distinct_count = stats.distinct_count.map(|value| value as
u64);
+ // Generic nan count for floating point types
+ let nan_count = stats.nan_count.map(|value| value as u64);
Review Comment:
I feel that when this value is read from an external file rather than
generated by the internal writer, it should likely be treated as a metadata
error, but it should not interfere with normal data reading. BTW, I noticed
that `arrow-rs` misses handling `distinct_count` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
