Reranko05 commented on code in PR #50691:
URL: https://github.com/apache/arrow/pull/50691#discussion_r3667552519
##########
cpp/src/parquet/encryption/key_material.cc:
##########
@@ -122,36 +122,57 @@ std::string KeyMaterial::SerializeToJson(
bool is_double_wrapped, const std::string& kek_id,
const std::string& encoded_wrapped_kek, const std::string&
encoded_wrapped_dek,
bool is_internal_storage) {
- ObjectWriter json_writer;
- json_writer.SetString(kKeyMaterialTypeField, kKeyMaterialType1);
+ JsonWriter json_writer;
+
+ json_writer.StartObject();
+
+ json_writer.Key(kKeyMaterialTypeField);
+ json_writer.String(kKeyMaterialType1);
if (is_internal_storage) {
- // 1. for internal storage, key material and key metadata are the same.
- // adding the "internalStorage" field that belongs to KeyMetadata.
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
