tustvold commented on code in PR #10454:
URL: https://github.com/apache/arrow-rs/pull/10454#discussion_r3669017932
##########
parquet/Cargo.toml:
##########
@@ -91,7 +95,11 @@ arrow = { workspace = true, features = ["ipc", "test_utils",
"prettyprint", "jso
arrow-cast = { workspace = true }
tokio = { version = "1.0", default-features = false, features = ["macros",
"rt-multi-thread", "io-util", "fs"] }
rand = { version = "0.9", default-features = false, features = ["std",
"std_rng", "thread_rng"] }
-object_store = { workspace = true, features = ["azure", "fs"] }
+# Enable the store implementations used by tests, doctests and benchmarks for
every
+# supported object_store version. Only the version selected by the enabled
feature flag is
+# used, tests access it via the `parquet::object_store` re-export rather than
by name
+object_store_0_13 = { package = "object_store", version = "0.13.2", features =
["azure", "fs"] }
Review Comment:
We need to keep these so that we get the feature flags, it is a bit meh
having the tests depend on two versions of object_store though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
