fallintoplace opened a new pull request, #1044:
URL: https://github.com/apache/arrow-go/pull/1044

   ## What changed
   
   Clone mutable Flight session option protobufs when storing and retrieving 
individual option values.
   
   ## Why
   
   The stateful session implementation previously stored caller-owned pointers 
and returned its internal pointers after releasing the mutex. Callers could 
therefore mutate session state outside synchronization, despite the 
implementation's goroutine-safety contract.
   
   The regression test covers both aliasing directions: modifying the input 
after `SetSessionOption` and modifying the value returned by `GetSessionOption`.
   
   ## Validation
   
   `go test ./arrow/flight/session`
   
   `go test -race ./arrow/flight/session`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to