lidavidm commented on code in PR #4612:
URL: https://github.com/apache/arrow-adbc/pull/4612#discussion_r3670067340
##########
c/driver/postgresql/postgres_type.h:
##########
@@ -608,6 +609,21 @@ inline ArrowErrorCode PostgresType::FromSchema(const
PostgresTypeResolver& resol
return EINVAL;
}
+ if (schema_view.extension_name.data != nullptr &&
+ std::string_view(schema_view.extension_name.data,
+ schema_view.extension_name.size_bytes)
Review Comment:
nit, but you could probably factor this out as it also occurs above (and if
the extension is nullptr then just use an empty/default-initialized string view)
##########
c/driver/postgresql/postgresql_test.cc:
##########
Review Comment:
You could perhaps add a validation case instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
