JakeDern commented on code in PR #10128:
URL: https://github.com/apache/arrow-rs/pull/10128#discussion_r3670828809
##########
arrow-ipc/src/writer.rs:
##########
@@ -333,6 +325,28 @@ impl Default for IpcWriteOptions {
/// [Arrow IPC Format]:
https://arrow.apache.org/docs/format/Columnar.html#serialization-and-interprocess-communication-ipc
pub struct IpcDataGenerator {}
+/// A dictionary determined to need sending as a part of a record batch.
+struct DictionaryToEncode {
+ id: i64,
+ data: ArrayData,
+ is_delta: bool,
+}
+
+/// The result of encoding a record batch's body and flatbuffer `RecordBatch`
table
+/// via [`IpcDataGenerator::encode_record_batch_data`].
+///
+/// The `RecordBatch` table is left in-progress in the caller's
[`FlatBufferBuilder`];
+/// the caller wraps `record_batch` in a `Message` (directly for a record batch
+/// message, or inside a `DictionaryBatch` for a dictionary message).
+struct EncodedRecordBatch {
Review Comment:
Yeah fair enough, I also renamed the `record_batch` field to `fb_offset`
since it's the flatbuffer offset part of the record batch metadata. I think
that makes sense 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
