jtanx opened a new pull request, #4627: URL: https://github.com/apache/arrow-adbc/pull/4627
I noticed that this code was basically incorrect if the msg size was larger than the reserved size of 1024: https://github.com/apache/arrow-adbc/blob/main/c/driver/postgresql/error.cc#L104 To do that properly would require resizing the buffer and rerunning vsnprintf. But stepping back, this function seems basically pointless as MakeStatus is already taking format args, so have just inlined the usage of this function with direct MakeStatus calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
