taepper commented on PR #50714:
URL: https://github.com/apache/arrow/pull/50714#issuecomment-5119845885

   @pitrou For this case:
   
   ```
   template <typename Type, typename ConsumeValue, typename ConsumeNull>
     requires std::is_void_v<
         std::invoke_result_t<ConsumeValue, uint32_t, typename 
GetViewType<Type>::T>>
   void VisitGroupedValues(const ExecSpan& batch, ConsumeValue&& valid_func,
                           ConsumeNull&& null_func) {
   ```
   
   I used `typename GetViewType<Type>::T` to e.g. map from `Int32Type` to 
`int32_t` / `Decimal128Type` to `Decimal128`. Is this the idiomatic way (we are 
not using a `View` here)? I did not find another readily apparent version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to