bit2swaz commented on PR #10431: URL: https://github.com/apache/arrow-rs/pull/10431#issuecomment-5120687187
made those changes. all fields private on all three structs now. you were both right, the data fields are UB vectors too so leaving them `pub` was a hole. thats my bad on the earlier "harmless" take. reads didnt need anything, every field already has a getter kept the `unsafe` setters for `release` + `private_data` since thats all the wrap-release flow writes. left a note on @alamb's `new_from_parts` thread on why i skipped it for now, happy to add it if you want tho `#[repr(C)]` is untouched so the layout/abi is identical. lmk if anything else is needed from my side :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
