alinaliBQ commented on code in PR #50700: URL: https://github.com/apache/arrow/pull/50700#discussion_r3676935582
########## cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_statement.cc: ########## @@ -784,11 +784,7 @@ SQLRETURN ODBCStatement::GetData(SQLSMALLINT record_number, SQLSMALLINT c_type, Review Comment: The CI hasn't run the C++ Extra tests, so I'm not sure whether `TestSQLMoreResultsWithoutQuery` will fail. If the driver manager doesn't `HY010` for `SQLMoreResults`, you may need to update `TestSQLMoreResultsWithoutQuery` to expect `SQL_NO_DATA` on all platforms. https://github.com/apache/arrow/blob/deed9c0d99b33be112f9931ec92f4df65c75fc43/cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc#L1986-L1995 to: ``` TYPED_TEST(StatementTest, TestSQLMoreResultsWithoutQuery) { ASSERT_EQ(SQL_NO_DATA, SQLMoreResults(this->stmt)); } ``` edit: fixed typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
