dk3yyyy opened a new pull request, #10486: URL: https://github.com/apache/arrow-rs/pull/10486
# Which issue does this PR close? - Closes #10476. # Rationale for this change The JSON reader constructs `ListView` arrays without validating child nullability. As a result, JSON containing `null` can be accepted for a non-nullable child field. # What changes are included in this PR? - Replace unchecked `ListView` construction with `GenericListViewArray::try_new`, returning an `ArrowError` when child nullability is invalid. - Add regression coverage for both `ListView` and `LargeListView`. # Are these changes tested? Yes: - `cargo test -p arrow-json reader::tests::test_read_list_view_rejects_null_non_nullable_child -- --exact` - `cargo test -p arrow-json --all-features` - `cargo clippy --workspace --all-targets --all-features -- -D warnings` - `cargo fmt --all -- --check` - `git diff --check` # Are there any user-facing changes? Yes. Invalid JSON containing a null inside a non-nullable `ListView` or `LargeListView` child now returns an error. There is no public API change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
