Jefffrey commented on code in PR #10485:
URL: https://github.com/apache/arrow-rs/pull/10485#discussion_r3679304670
##########
arrow-json/src/reader/mod.rs:
##########
@@ -845,9 +845,9 @@ fn make_decoder(
DataType::BinaryView => Ok(Box::new(BinaryViewDecoder::default())),
DataType::Map(_, _) => Ok(Box::new(MapArrayDecoder::new(ctx,
data_type, is_nullable)?)),
DataType::RunEndEncoded(ref r, _) => match r.data_type() {
- DataType::Int16 =>
Ok(Box::new(RunEndEncodedArrayDecoder::<Int16Type>::new(ctx, data_type,
is_nullable)?)),
Review Comment:
this ignoring of the passed in `is_nullable` seems significant; is it safe
to do this? 🤔
cant help but feel this could lead to another edge case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
