Punisheroot commented on code in PR #50710:
URL: https://github.com/apache/arrow/pull/50710#discussion_r3681696854
##########
cpp/src/parquet/decoder.cc:
##########
@@ -2372,6 +2472,31 @@ class ByteStreamSplitDecoder<FLBAType> : public
ByteStreamSplitDecoderBase<FLBAT
}
};
+// Keep chunk rollover out of the hot decoder functions that instantiate this
helper.
+Status
+ArrowBinaryHelper<ByteArrayType,
::arrow::BinaryType>::AppendValueWithKnownSizeSlow(
+ const uint8_t* data, int32_t length, int64_t
estimated_remaining_data_length) {
+ RETURN_NOT_OK(PushChunk());
+ RETURN_NOT_OK(ReserveInitialChunkData(estimated_remaining_data_length));
+ chunk_space_remaining_ -= length;
+ --entries_remaining_;
+ builder_->UnsafeAppend(data, length);
Review Comment:
Addressed in 8afeae82dbee43a1d155d912a0e58cf8f97507fd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
