serramatutu commented on code in PR #1066:
URL: https://github.com/apache/arrow-go/pull/1066#discussion_r3682641337
##########
arrow/flight/flightsql/client_test.go:
##########
@@ -43,6 +43,21 @@ type mockGrpcClientStream struct {
mock.Mock
}
+type referenceCountingReader struct {
Review Comment:
This ref counting mechanism is used only in one place and is not a
widespread architectural pattern. To me this is a signal that this is a
workaround for a bug instead of an actual good fix.
I think the proper solution for readers is ensuring we do lifecycle
management right (i.e call `Retain()` in the right places) instead of adding
ref counting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
