Rich-T-kid commented on PR #10441: URL: https://github.com/apache/arrow-rs/pull/10441#issuecomment-5134311265
https://github.com/apache/arrow-rs/pull/10441/commits/2947869ac8b330768c504862f22d18f019076adc compared to main <img width="1794" height="822" alt="Image 7-30-26 at 1 40 PM" src="https://github.com/user-attachments/assets/d39b1954-c2ad-4fe6-ae6a-d11715f8cb1c"; /> we should also run adriabot again. This PR (https://github.com/apache/arrow-rs/pull/10441/commits/2947869ac8b330768c504862f22d18f019076adc) threads a generic parameter through a couple of functions. It's just a simple flag that determines whether value_unchecked() is used instead of array[index]. This was the most minimal change I could think of without duplicating code. The approach has zero overhead for the current safe code path due to Rust's monomorphization, each const gets replaced with its true/false branch, and dead code analysis removes the alternative branch, meaning there won't be any actual repeated comparisons within the functions. any thoughts @alamb @Jefffrey ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
