viirya commented on PR #50430: URL: https://github.com/apache/arrow/pull/50430#issuecomment-5136225777
Note on the Copilot assessment above: the ordering difference it describes (lazy vs upfront key conversion) is real but deliberate — the keys-first pass existed precisely to mirror `MapScalar.as_py`'s ordering and was removed in 93b80439a8 following the review discussion that the exact exception/warning interleaving isn't part of the contract. It's only observable when a later key's own conversion raises (e.g. invalid UTF-8 in a string key). Happy to restore the keys-first pass if we do want that ordering pinned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
