raulcd commented on code in PR #50407:
URL: https://github.com/apache/arrow/pull/50407#discussion_r3689603904
##########
ci/docker/ubuntu-22.04-cpp.dockerfile:
##########
@@ -223,6 +223,8 @@ ENV absl_SOURCE=BUNDLED \
google_cloud_cpp_storage_SOURCE=BUNDLED \
opentelemetry_cpp_SOURCE=BUNDLED \
ORC_SOURCE=BUNDLED \
+ Protobuf_SOURCE=BUNDLED \
+ gRPC_SOURCE=BUNDLED \
Review Comment:
We should probably bump `ARROW_GRPC_REQUIRED_VERSION`. I am pretty sure if
Ubuntu 20.04 ships older GRPC than necessary, we will also have to update the
Linux Package jobs (.deb) for old ubuntu (potentially also for old Red Hat?),
I'll kick off Linux Packages.
##########
cpp/src/arrow/flight/transport/grpc/customize_grpc.h:
##########
@@ -86,6 +86,16 @@ ::grpc::Status FlightDataSerialize(const
arrow::flight::FlightPayload& msg,
// protobuf without copying
ARROW_FLIGHT_EXPORT ::grpc::Status FlightDataDeserialize(
::grpc::ByteBuffer* buffer, arrow::flight::internal::FlightData* out);
+
+ARROW_FLIGHT_EXPORT
+bool IsRegisteredGrpcFlightDataMessage(
Review Comment:
we should add some comments on why now we have to register/unregister
FlightData messages. Are those necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
