alamb commented on PR #10297: URL: https://github.com/apache/arrow-rs/pull/10297#issuecomment-5147036600
I hit an error due to this change when testing the upgrade to DataFusion: - https://github.com/apache/datafusion/pull/24030 I was working on - https://github.com/apache/arrow-rs/issues/9879 Here are the errors - https://github.com/alamb/datafusion/actions/runs/30643722834/job/91201627268 - https://github.com/alamb/datafusion/actions/runs/30643722834/job/91201627088 ``` thread 'tokio-rt-worker' (41727) panicked at /usr/local/cargo/git/checkouts/arrow-rs-583cca34693b79b8/1359cb9/arrow-array/src/array/struct_array.rs:91:46: called `Result::unwrap()` on an `Err` value: InvalidArgumentError("Incorrect datatype for StructArray field \"metadata\", expected Map(\"entries\": non-null Struct(\"keys\": non-null Utf8, \"values\": Utf8), unsorted) got Map(\"entries\": non-null Struct(\"key\": non-null Utf8, \"value\": Utf8), unsorted)") stack backtrace: ``` I think this PR is a good one to align to the spec, but I think we should probably treat it as a "breaking API change" and hold it for the next breaking release to minimize downstream churn on a minor release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
