Abhisheklearn12 commented on code in PR #10510:
URL: https://github.com/apache/arrow-rs/pull/10510#discussion_r3698156636
##########
arrow-cast/src/cast/dictionary.rs:
##########
@@ -141,9 +143,24 @@ fn view_from_dict_values<K: ArrowDictionaryKeyType, V:
ByteArrayType, T: ByteVie
ArrowError::ComputeError("Invalid dictionary
index".to_string())
})?;
+ // A dictionary built without validation can carry a key past
the end of the
+ // values. Reject it rather than reading out of bounds below.
+ if idx >= values.len() {
+ return Err(ArrowError::InvalidArgumentError(format!(
+ "Dictionary key {idx} out of bounds for dictionary
values of length {}",
+ values.len()
+ )));
+ }
+
Review Comment:
ohh, i checked, you're right. `try_new` and `ArrayDataBuilder::build()` both
validate the key range, so i'd need `new_unchecked` to get there, removing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
