Anakin100100 opened a new pull request, #10518:
URL: https://github.com/apache/arrow-rs/pull/10518
# Which issue does this PR close?
Part of #10245
# Rationale for this change
Improves performance of the arithmetic kernels operating on primite types.
# What changes are included in this PR?
I read the issue and focused on try_binary and discovered a few other
optimizations there. All mentions of benchmarks here refer to
decimal_arithmetic benchmark which covers addition and subtraction on
binary: replaced iterator collect with a direct loop which LLVM can better
optimize and avoids option checks. The loop overhead here is a large part of
the runtime when the underlying op is simple.
try_binary: in the null path uses Vec directly to create the buffer instead
of going through the BufferBuilder. I tested it with a benchmark with 10-90%
nulls and there is 5-9% improvement to the overall runtime. I don't think
there's reason to include this benchmark in the library because it's very
specific to this path and not general enough to be useful in the future.
try_binary_no_nulls: the typed array slice write can be vectorized more
easily, Independent of that I verified that removing the no-inline annotation
increases performance by additional 5% which makes sense with a more direct
loop.
On average these changes increase the throughput of the kernels by 26-27% on
same scale and 14-15% of different scale benchamrks for 32 and 64 bit types
because the loop is a smaller fraction in the second case.
```bash
decimal32_equal_scale/sub
time: [917.00 ns 923.95 ns 932.62 ns]
thrpt: [1.0980 Gelem/s 1.1083 Gelem/s 1.1167
Gelem/s]
change:
time: [−23.032% −21.954% −20.901%] (p = 0.00 <
0.05)
thrpt: [+26.424% +28.130% +29.924%]
decimal64_different_scale/add
time: [1.9084 µs 1.9212 µs 1.9366 µs]
thrpt: [528.77 Melem/s 533.00 Melem/s 536.59
Melem/s]
change:
time: [−15.134% −14.025% −12.902%] (p = 0.00 <
0.05)
thrpt: [+14.813% +16.313% +17.833%]
```
On 128 and 256 bit types there is around 5% speedup because of more complex
math behind the underlying op.
# Are these changes tested?
Yes, already covered by tests.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
