kou commented on code in PR #50650:
URL: https://github.com/apache/arrow/pull/50650#discussion_r3703668028
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4326,14 +4302,18 @@ function(build_azure_sdk)
set(AZURE_SDK_VENDORED
TRUE
PARENT_SCOPE)
+ list(PREPEND
Review Comment:
Hmm, no.
We build bundled dependencies from products that are depended upon (e.g.
Abseil) to products that depend on them (e.g. Protobuf). If we use `APPEND`,
`ARROW_BUNDLED_STATIC_LIBS` uses Abseil -> Protobuf order. In general, static
linking command line uses Protobuf -> Abseil order to resolve Abseil symbols in
Protobuf. But this may not be needed for `libarrow_bundled_dependencies.a`
because it includes all symbols in one `.a`.
If we ensure using produces that are depended upon -> products that depend
on them order, we can't use alphabetical order for all Abseil CMake targets
(`absl::*`). But in this PR, I used alphabetical order for Abseil CMake targets
because I don't want to check all dependency list. And it works.
Should we keep using `APPEND` because `PREPEND` may show that we want to use
produces that are depended upon -> products that depend on them order?
##########
dev/tasks/linux-packages/apache-arrow/Rakefile:
##########
@@ -98,9 +98,29 @@ class ApacheArrowPackageTask < PackageTask
control.gsub(/@CUDA_ARCHITECTURE@/, cuda_architecture)
end
+ def apt_prepare_debian_control_open_telemetry(control, target)
+ case target
+ when /\Aubuntu-(?:jammy|noble)/
Review Comment:
Right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
