KHARSHAVARDHAN-eng opened a new pull request, #50783:
URL: https://github.com/apache/arrow/pull/50783
### Rationale for this change
This is part of sub-issue #44748 to clean up ShellCheck warnings in Apache
Arrow shell scripts.
* SC1091: Not following: ./bin/activate: openBinaryFile: does not exist (No
such file or directory)
* SC2086: Double quote to prevent globbing and word splitting.
* SC2223: This default assignment may cause DoS due to globbing. Quote it.
### What changes are included in this PR?
* SC1091: Add `# shellcheck source=/dev/null` directive.
* SC2086: Quote variable expansions (`pushd "${source_dir}"`).
* SC2223: Quote default variable assignments (`: "${R_BIN:=R}"`).
* Update `.pre-commit-config.yaml` to enable ShellCheck for
`ci/scripts/r_test.sh`.
### Are these changes tested?
Yes. Executed:
- `shellcheck ci/scripts/r_test.sh` (0 warnings)
- `git diff --check` (clean)
### Are there any user-facing changes?
No.
Closes #50777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
