olivroy commented on PR #50525: URL: https://github.com/apache/arrow/pull/50525#issuecomment-5168008484
Sure, here is the rationale here: * I add ~ 100 lines of code (93 of them are just for added snapshot tests) I copied `check_logical()` and `check_character()` from rlang to validate arguments are character or logical vectors , so no maintenance is anticipated there (~ 70 lines of code) The only significant thing thing this PR adds is the migration of `assert_is()` to rlang type-checkers (it could be renamed to `check_class()` actually to standardize error messages and is used throughout. `check_null()` is a simple function that errors if `x` is not NULL (used 4 times) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
