amoeba commented on code in PR #4643:
URL: https://github.com/apache/arrow-adbc/pull/4643#discussion_r3706835773


##########
c/driver_manager/adbc_driver_manager_test.cc:
##########


Review Comment:
   ```suggestion
     auto filepath = temp_dir / "test_sqlite.toml";
   ```



##########
c/driver_manager/adbc_driver_manager_test.cc:
##########


Review Comment:
   ```suggestion
     ASSERT_THAT(AdbcDatabaseSetOption(&database.value, "driver", 
"test_sqlite", &error),
   ```



##########
c/driver_manager/adbc_driver_manager_test.cc:
##########


Review Comment:
   ```suggestion
     ASSERT_THAT(error.message, ::testing::HasSubstr("test_sqlite.toml but:"));
   ```



##########
c/driver_manager/adbc_driver_manager_test.cc:
##########


Review Comment:
   ```suggestion
     auto filepath = temp_dir / "test_sqlite.toml";
   ```



##########
c/driver_manager/adbc_driver_manager_test.cc:
##########


Review Comment:
   ```suggestion
     ASSERT_THAT(AdbcDatabaseSetOption(&database.value, "driver", 
"test_sqlite", &error),
   ```



##########
c/driver_manager/adbc_driver_manager_test.cc:
##########


Review Comment:
   ```suggestion
     ASSERT_THAT(error.message, ::testing::HasSubstr("test_sqlite.toml but:"));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to