rok commented on code in PR #50685:
URL: https://github.com/apache/arrow/pull/50685#discussion_r3711644054
##########
python/pyarrow/feather.py:
##########
@@ -127,11 +118,6 @@ def write_feather(df, dest, compression=None,
compression_level=None,
"""
Write a pandas.DataFrame to Feather format.
Review Comment:
```suggestion
.. deprecated:: 25.0.0
Writing Feather V1 files is deprecated. Use the default
``version=2`` to write Arrow IPC files instead.
```
##########
docs/source/python/feather.rst:
##########
Review Comment:
Here I would add something like:
```suggestion
.. note::
``pyarrow.feather.write_feather`` and ``pyarrow.feather.read_table``
equivalents will be provided in `pyarrow.ipc` before the
``pyarrow.feather`` module is deprecated.
```
##########
python/pyarrow/feather.py:
##########
@@ -150,15 +136,20 @@ def write_feather(df, dest, compression=None,
compression_level=None,
which is currently 64K
version : int, default 2
Feather file version. Version 2 is the current. Version 1 is the more
- limited legacy format
+ limited legacy format.
+
+ .. deprecated:: 25.0.0
+ Writing Feather V1 files is deprecated. Use the default
+ ``version=2`` to write Arrow IPC files instead.
Review Comment:
Let's minimize the change here. Move deprecation text above where it used to
be and there only update the text.
```suggestion
limited legacy format
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
