emilk opened a new pull request, #10558: URL: https://github.com/apache/arrow-rs/pull/10558
# Which issue does this PR close? No issue in particular - Stacked on top of #10552 — only the last 10 commits belong to this PR - Follow-up to #10533 - Related to #10458 # Rationale for this change Continues filling out `[workspace.lints.clippy]` from [egui's `Cargo.toml`](https://github.com/emilk/egui/blob/main/Cargo.toml), one lint per commit so individual lints are easy to drop. # What changes are included in this PR? Ten more lints, each with its fixes: `ref_option`, `precedence_bits`, `doc_link_with_quotes`, `manual_string_new`, `explicit_into_iter_loop`, `manual_is_variant_and`, `equatable_if_let`, `needless_raw_string_hashes`, `ignored_unit_patterns` and `unnested_or_patterns`. Most were applied with `cargo clippy --fix`. `ref_option` and `doc_link_with_quotes` were done by hand. `doc_link_with_quotes` found ten intra-doc links written with `'` instead of backticks, so they rendered as plain text instead of linking. # Are these changes tested? Yes, by existing CI. Clippy is at zero warnings after every individual commit, and the tests of each affected crate pass. # Are there any user-facing changes? No public API changed: every `ref_option` signature that changed is private or `pub(crate)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
