Abhisheklearn12 commented on PR #10436: URL: https://github.com/apache/arrow-rs/pull/10436#issuecomment-5190993231
> what benchmarks am i looking at here? cast kernels seems to only have a single related benchmark, for `dict<utf8> -> utf8view` > > can we add these benchmarks in a separate PR so we can verify with the bot (ideally keeping the minimum required, e.g. don't need both largestring -> utf8view and largebinary -> binaryview since theyre essentially the same code paths) well, those numbers came from a local harness rather than anything checked in, which is why they aren't in the repo. i'll add the benchmarks in a separate pr so the bot can verify them. agreed on keeping the set minimal. `view_from_dict_values` is generic, so `largeutf8 -> utf8view` and `largebinary -> binaryview` are really the same implementation with different type params. i think the minimum set would be: - `dict<utf8> -> utf8view` - `dict<largeutf8> -> utf8view` to cover the i64 offset path - `dict<binary> -> utf8view`, since that goes through utf8 validation and has a different cost profile the existing `cast dict to string view` benchmark already covers the dense path. does that sound right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
