zeroshade commented on PR #1036: URL: https://github.com/apache/arrow-go/pull/1036#issuecomment-5193731349
@tom-eon The actual bug is the compression-blind cost check, which only makes sense when the data is uncompressed. Could we gate this fallback on "compression is Uncompressed", or otherwise make it codec-aware, so we fix the misprediction on the common compressed case? We can keep the per-column opt-out option you've added, but adding the codec-aware default would fix this for everyone without requiring users to find and use this knob. The PR in general looks good otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
