Jefffrey commented on code in PR #10571:
URL: https://github.com/apache/arrow-rs/pull/10571#discussion_r3732551688
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -552,7 +571,7 @@ impl std::ops::Deref for Buffer {
}
}
-impl AsRef<[u8]> for &Buffer {
+impl AsRef<[u8]> for Buffer {
Review Comment:
this makes sense, and i think its not breaking since the standard library
has a blanket implementation for asref
https://doc.rust-lang.org/std/convert/trait.AsRef.html#impl-AsRef%3CU%3E-for-%26T
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
