alamb opened a new pull request, #10586: URL: https://github.com/apache/arrow-rs/pull/10586
# Which issue does this PR close? - Related to https://github.com/apache/arrow-rs/pull/10157 # Rationale for this change It seems https://github.com/apache/arrow-rs/pull/10157 has a logical conflict with newly added clippy lints After merging https://github.com/apache/arrow-rs/pull/10157 it is failing with For example: https://github.com/apache/arrow-rs/actions/runs/31189404230/job/92902082102 ``` warning: unnested or-patterns --> parquet-variant-compute/src/shred_variant.rs:3134:17 | 3134 | / (Variant::Int8(_), DataType::Int8) 3135 | | | (Variant::Int8(_), DataType::Int16) 3136 | | | (Variant::Int8(_), DataType::Int32) 3137 | | | (Variant::Int8(_), DataType::Int64) ... | 3228 | | | (Variant::String(_), DataType::LargeUtf8) 3229 | | | (Variant::Time(_), DataType::Time64(_)) | |_____________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#unnested_or_patterns = note: requested on the command line with `-W clippy::unnested-or-patterns` help: nest the patterns | 3134 ~ (Variant::Int8(_) | Variant::Int16(_) | Variant::Int32(_) | Variant::Int64(_) 3135 + | Variant::Decimal4(_) | Variant::Decimal8(_) | Variant::Decimal16(_), 3136 + DataType::Int8) | 3137 + (Variant::Int8(_) | Variant::Int16(_) | Variant::Int32(_) | Variant::Int64(_) 3138 + | Variant::Decimal4(_) | Variant::Decimal8(_) | Variant::Decimal16(_), 3139 + DataType::Int16) | ``` # What changes are included in this PR? Do what clippy says (just accept its suggestion) # Are these changes tested? By CI # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
