fallintoplace opened a new pull request, #1144:
URL: https://github.com/apache/arrow-go/pull/1144

   ### Rationale for this change
   
   `BufferWriter` mixed logical positions with physical buffer offsets. This 
made reservations too small, placed `UnsafeWriteCopy` at the wrong location, 
truncated buffers after `UnsafeWrite`, and applied the offset twice during 
`Seek`.
   
   ### What changes are included in this PR?
   
   Keep reservations, writes, length reporting, and seeking consistent with the 
configured offset. Add focused tests for regular writes, unsafe pattern writes, 
and seeking.
   
   ### Are these changes tested?
   
   - `go test ./parquet/internal/encoding`
   - `go test -race ./parquet/internal/encoding -run TestBufferWriter`
   
   ### Are there any user-facing changes?
   
   Parquet buffer writers now preserve the expected logical position and length 
when an offset is used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to