YUZHEthefool opened a new pull request, #10600: URL: https://github.com/apache/arrow-rs/pull/10600
Which issue does this PR close? None. Rationale for this change arrow_ord::rank gained a Utf8View/BinaryView path (byte_view_rank) in #10559, but the rank benchmarks in arrow/benches/sort_kernel.rs were not updated—they only cover the primitive_rank (f32) and bytes_rank (string[10]) paths, so the new view path has no benchmark coverage. The sort/sort_to_indices benchmarks in the same file already cover string_view, so this brings rank in line with them. byte_view_rank reads values from the view layout rather than the contiguous buffer used by bytes_rank, and the fixed- vs variable-length shapes decide how often a value spills out of the inline prefix into a separate buffer—both worth measuring on their own. What changes are included in this PR? Adds rank string_view[10] and rank string_view[0-400] benchmarks (each with and without nulls), mirroring the existing sort string_view cases. Reuses the create_string_view_array* helpers from bench_util—no new helpers. Are there any user-facing changes? No. # Which issue does this PR close? - Closes https://github.com/apache/arrow-rs/issues/10599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
