lidavidm commented on code in PR #4634:
URL: https://github.com/apache/arrow-adbc/pull/4634#discussion_r3747678253
##########
.github/workflows/javascript.yml:
##########
@@ -169,18 +173,35 @@ jobs:
name: bindings-${{ matrix.settings.target }}
path: javascript
- name: Setup conda (Windows)
- if: runner.os == 'Windows'
+ # Miniforge does not publish a Windows ARM64 installer, so the ARM64
+ # leg gets SQLite from vcpkg below instead.
+ if: runner.os == 'Windows' && runner.arch != 'ARM64'
uses:
conda-incubator/setup-miniconda@8ee1f361103df19b6f8c8655fd3967a8ecb162d5 #
v4.0.1
with:
miniforge-version: latest
- name: Install C++ dependencies (Windows)
- if: runner.os == 'Windows'
+ if: runner.os == 'Windows' && runner.arch != 'ARM64'
run: conda install -c conda-forge --file ci/conda_env_cpp.txt
Review Comment:
Ok, I think my other question here is whether we _really_ need conda in the
first place? If we're just building the sqlite driver to test against, maybe we
can rely on system libsqlite or vcpkg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
